Arteebee adapter GDPR integration #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
requested changes
May 29, 2018
There was a problem hiding this comment.
Hello @jeffyecn I was testing out the adapter using the test param information in the .md file, and I was seeing a 400 Bad Request error on the server request.
Below is a copy of the request object that returned the error:
{"imp":[{"id":"2b4b011b89aad","banner":{"format":[{"w":300,"h":250},{"w":300,"h":600}]}}],"site":{"id":"prebidtest","page":"http://ap.localhost:9999/integrationExamples/gpt/gdpr_hello_world.html?pbjs_debug=true","ref":"http://ap.localhost:9999/integrationExamples/gpt/gdpr_hello_world.html?pbjs_debug=true","publisher":{"id":"prebidtest","domain":"ap.localhost:9999"}},"device":{"ua":"caller","ip":"caller","js":1},"at":1,"tmax":3000,"regs":{"ext":{"gdpr":1}},"user":{"ext":{"consent":"BOOUW7QOOUW7QABABAENAd-AAAAVl7_______9____7_9uz_Gv_r_ff_3nW0739P1A_r_Oz_qG_6xzVo4_FpQAQ"}},"test":1}
Could you take a look to see why the error is happening? Is there an updated set of test params to use?
|
Hi, @jsnellbaker Code has been updated to fix this issue. |
jsnellbaker
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add support for GDPR via consent manager module and related test case
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Add GDPR supported flag to Arteebee bid adapter prebid.github.io#806
Other information